This repository has been archived by the owner on Aug 16, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 114
chore(base images): decouple build of base images to separate gh-action #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitaliy-guliy
changed the title
chore(base images): switch from digests to tags
chore(base images): decouple build of base images to separate gh-action
Sep 8, 2021
… image Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>
vitaliy-guliy
force-pushed
the
che-19695
branch
from
October 1, 2021 12:05
4083543
to
3939f3d
Compare
vitaliy-guliy
requested review from
benoitf,
JPinkney,
sunix,
svor,
tsmaeder and
vinokurig
as code owners
October 1, 2021 12:10
benoitf
reviewed
Oct 1, 2021
Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>
Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>
benoitf
approved these changes
Oct 4, 2021
svor
reviewed
Oct 4, 2021
Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>
svor
approved these changes
Oct 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I've tried to build all images and specific one, have not detected any problem.
This was referenced Oct 5, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vitaliy Gulyy vgulyy@redhat.com
What does this PR do?
Introduces a set of dockerfiles and scripts withing GitHub actions to build sidecar images.
Sidecar dockerfiles are placed in
dockerfiles
directory. This directory contains as wellbuild.sh
script to build all or specific sidecar image(s).GitHub actions / Workflow
Checks sidecar parent image on updates.
The action runs
./build/workflows/check-sidecar-image-digests.sh --pr
.This script
We will merge this pull request by hands.
The action is triggered when merging anything to
main
branch todockerfiles
directory.Action runs
./build/workflows/build-sidecar-images-on-push.sh --push --rm --update-devfiles
, whichdockerfiles/build.sh
script. All the sidecar images will be rebuilt if changes were inbase.dockerfile
,entrypoint.sh
or ininstall-editor-tooling.sh
quay.io
On the next step action runs
./build/workflows/bump-devfiles-to-new-sidecar-tags.sh --pr
whichWe will merge this pull request by hands.
Following improvement
Release scripts will be fixed after merging this PR and pushing new sidecar images (with new tags) to
quay.io
.Usage of
base_images
file will be also cut when refactoring the release scripts.Screenshot/screencast of this PR
What issues does this PR fix or reference?
eclipse-che/che#19695
How to test this PR?
che-19695
branch2. Test with devfile
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.